Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate HEMCO_CESM preprocessor constant. Now use MODEL_CESM #197

Merged

Conversation

jimmielin
Copy link
Collaborator

Name and Institution (Required)

Name: Haipeng Lin
Institution: Harvard Univ.

Confirm you have reviewed the following documentation

Describe the update

Changes HEMCO_CESM pre-processor constant to MODEL_CESM.
We are deprecating the HEMCO_CESM pre-processor constant in preparation for merge of HEMCO into CESM. Now only MODEL_CESM is used.

Expected changes

No model output changes are expected.

Thanks!
Haipeng

@yantosca yantosca added this to the 3.7.0 milestone Mar 2, 2023
@yantosca yantosca added category: Feature Request New feature or request category: Interface to External Model Related to HEMCO updates needed to interface with other models (GEOS, WRF, CESM, etc) no-diff-to-benchmark This update will have no impact on benchmark simulations labels Mar 2, 2023
@lizziel lizziel self-requested a review March 2, 2023 22:08
src/Core/hco_types_mod.F90 Show resolved Hide resolved
Copy link
Contributor

@lizziel lizziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge.

@msulprizio msulprizio merged commit 1cc25af into geoschem:dev/3.7.0 Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Feature Request New feature or request category: Interface to External Model Related to HEMCO updates needed to interface with other models (GEOS, WRF, CESM, etc) no-diff-to-benchmark This update will have no impact on benchmark simulations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants