Use test fixtures from Nanevski et al (2001) #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As noted, all of the new tests are currently generating failures, so it's possible that it's due to an error on my part, though I can't find anything obviously wrong. |
|
Test failures now only occurring on orient2d Line 1: and insphere Line 1: Which is progress. |
|
These are now all passing! |
urschrei
commented
Mar 16, 2023
urschrei
force-pushed
the
test_fixtures
branch
2 times, most recently
from
34ec7b8 to
ab21d4d
Compare
|
👍 with much appreciation! Thanks @urschrei . Please merge both when you feel ready. We could then publish a version shortly after. |
Closed
frewsxcv
approved these changes
Mar 26, 2023
|
bors r=rmanoka |
bors bot
added a commit
that referenced
this pull request
Mar 27, 2023
24: Use test fixtures from Nanevski et al (2001) r=rmanoka a=urschrei Ported over from https://github.com/mourner/robust-predicates/tree/main/test/fixtures This PR is based on #23, which should be merged first. Co-authored-by: Stephan Hügel <[email protected]>
This provides tests for all four top-level functions
|
Canceled. |
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported over from https://github.com/mourner/robust-predicates/tree/main/test/fixtures
This PR is based on #23, which should be merged first.