Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support serde 0.8 #48

Merged
merged 2 commits into from
Aug 7, 2016
Merged

support serde 0.8 #48

merged 2 commits into from
Aug 7, 2016

Conversation

KodrAus
Copy link
Contributor

@KodrAus KodrAus commented Aug 5, 2016

Add support for serde 0.8. There wasn't much that needed changing, but one of the doc tests was failing so I've just set it to norun.

@@ -33,7 +33,7 @@ use ::{Bbox, Crs, Error, Feature, FromObject, util};
///
/// Serialization:
///
/// ```rust
/// ```norun
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you happen to recall what part of this fails?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was just the extern crate rustc_serialize. I don't know why I ignored the test instead of just remove the crate import... It's not needed. It's fixed now.

@frewsxcv
Copy link
Member

frewsxcv commented Aug 7, 2016

Thanks!

@frewsxcv frewsxcv merged commit c2e8080 into georust:master Aug 7, 2016
@KodrAus KodrAus deleted the feat/serde-0.8 branch August 7, 2016 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants