Parse inner GeoJson members directly from str #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, nice! |
urschrei
approved these changes
May 27, 2022
michaelkirk
force-pushed
the
mkirk/parse-feature-collection
branch
from
0db2aca
to
39301f7
Compare
Before:
let gj = geojson::GeoJson::from_str(#r"{"type": "Geometry", "coordinates": [1, 2]}"#);
let geom = Geometry::try_from(gj);
After:
let geom = geojson::Geometry::from_str(#r"{"type": "Geometry", "coordinates": [1, 2]}"#);
michaelkirk
force-pushed
the
mkirk/parse-feature-collection
branch
from
39301f7
to
24769fc
Compare
|
rebased to fix conflict in CHANGES.md bors r=urschrei |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.A small ergonomics tweak:
Before:
After: