Incoming breakage: Replace an invalid #[deprecated]
attribute with a doc comment
#932
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.md
if knowledge of this change could be valuable to users.#[deprecated]
attributes onimpl
blocks do not have any effect and normally the deny-by-default lintuseless_deprecated
would be triggered with the message this#[deprecated]
annotation has no effect.However, there is a bug in the current version of the Rust compiler that makes it ignore the attribute entirely if it is malformed
which is the case for the
#[deprecated]
attached to theFrom
impl forGeometryCollection
(the version is not surrounded by double quotes).I've replaced the attribute with a documentation comment similar to the one for the softly deprecated associated function
GeometryCollection::new_from
.The compiler bug is about to be fixed (rust-lang/rust#104148) and the malformed attribute will soon become a hard error.
This future breakage was found with the help of crater (see the build log).