Rect constructor should enforce (min.x < max.x) and (min.y < max.y) #359
Comments
bors bot
added a commit
that referenced
this issue
May 26, 2019
360: Adding Rect constructor to address issue #359: r=frewsxcv a=Chopinsky To address the issue #359 of lacking a Rect geo-type constructor that can perform coordinates validations, I've made the following changes: 1. Add a `new` constructor to the Rect geo-type. 2. Update all internal use of the Rect struct literals to the new constructor. However, existing use of the Rect struct literals in unit tests are left alone. Co-authored-by: Jacob Zuo <[email protected]>
|
Please consider swapping the coords to enforce the constraint, rather than Use case: for instance, GDAL libraries use an inverted coord. system for the pixel vs world. That is, pixel (0,0) is top-left of raster in accordance with usual CV notion, while the min in true world coords (such as long, lat or other projected coords) occurs at bottom-left of the raster. It is intuitive to provide a point-wise transform function, which is expected to work on all shapes. Unfortunately, it breaks down with Can provide a PR if this makes sense to you. |
|
Looks like this was resolved with #360 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See
Use case 1in #354The text was updated successfully, but these errors were encountered: