Add Feature::unset_field #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @metasim |
rouault
reviewed
Dec 23, 2023
| /// See: [`OGRFeature::UnsetField`][UnsetField] | ||
| /// | ||
| /// [UnsetField]: https://gdal.org/api/ogrfeature_cpp.html#_CPPv4N10OGRFeature10UnsetFieldEi | ||
| pub fn unset_field(&self, field_name: &str) -> Result<()> { |
There was a problem hiding this comment.
I guess that should be (same for set_field_null())
Suggested change
| pub fn unset_field(&self, field_name: &str) -> Result<()> { | |
| pub fn unset_field(&mut self, field_name: &str) -> Result<()> { |
There was a problem hiding this comment.
It should, but all of these currently take &self for some reason and @metasim ran into some issues when trying to change them to &mut self.
There was a problem hiding this comment.
That's #499. I think it should work, but didn't try it yet.
rouault
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.