Maintenance cleanup on dataset.rs
#447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved non-core Dataset methods into respective `raster` or `vector` modules.
metasim
force-pushed
the
maintenance/dataset-refactor
branch
from
aaabd74 to
7f5d993
Compare
16 tasks
lnicola
reviewed
Oct 2, 2023
| @@ -611,7 +557,7 @@ impl Drop for FieldDefn { | |||
| } | |||
|
|
|||
| impl MajorObject for FieldDefn { | |||
| unsafe fn gdal_object_ptr(&self) -> GDALMajorObjectH { | |||
| fn gdal_object_ptr(&self) -> GDALMajorObjectH { | |||
lnicola
reviewed
Oct 2, 2023
lnicola
approved these changes
Oct 2, 2023
|
bors r=lnicola |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Changes:
dataset.rsinto their own or related files.rasterorvectormodules. Aims to simplify maintainability via "separation of concerns".unsafefrom pointer accessor methods.Possibly breaking changes:
LayerIterator,LayerOptionsandTransactiontocrate::vector.Aside: The impetus for this refactor is to focus the changes necessary for adding
Datasetto #445. But even if that PR takes a different route, this change will benefit long-term maintenance.