Consolidated fixture! implementation and enabled usage anywhere in module structure.
#342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…module structure.
metasim
commented
Nov 20, 2022
|
Removing the duplicated code and turning the macro into a function are good ideas, but I'm not sure what the extra environment variable is bringing. I suppose we could use it spread the test fixtures around, but we only have two crates now. It seems to me that the current arrangement (with paths relative to the manifest) is more predictable and easier to understand. |
🤔 🤦 I got so wrapped up the old implementation that I missed the "forest for the trees". Yeh, extra indirection is kinda silly. |
lnicola
reviewed
Dec 5, 2022
lnicola
approved these changes
Dec 5, 2022
|
bors r=lnicola |
2 tasks
bors bot
added a commit
that referenced
this pull request
May 17, 2023
397: Support for accessing the `SpatialRef` of GCPs. r=lnicola a=metasim - [X] I agree to follow the project's [code of conduct](https://github.com/georust/gdal/blob/master/CODE_OF_CONDUCT.md). - [X] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- Also removes trailing use of old `fixture!` macro originally removed in #342 Co-authored-by: Simeon H.K. Fitch <[email protected]>
bors bot
added a commit
that referenced
this pull request
May 17, 2023
397: Support for accessing the `SpatialRef` of GCPs. r=lnicola a=metasim - [X] I agree to follow the project's [code of conduct](https://github.com/georust/gdal/blob/master/CODE_OF_CONDUCT.md). - [X] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- Also removes trailing use of old `fixture!` macro originally removed in #342 Co-authored-by: Simeon H.K. Fitch <[email protected]>
bors bot
added a commit
that referenced
this pull request
May 17, 2023
397: Support for accessing the `SpatialRef` of GCPs. r=lnicola a=metasim - [X] I agree to follow the project's [code of conduct](https://github.com/georust/gdal/blob/master/CODE_OF_CONDUCT.md). - [X] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- Also removes trailing use of old `fixture!` macro originally removed in #342 Co-authored-by: Simeon H.K. Fitch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.There were two versions of
fixture!, and was working on a PR that needed a third, so this simplifies and consolidates the implementation by making use of relative paths in[env]section ofconfig.toml, passing the fully qualified path to the fixture directory to the compiler via an environment variable.