Added ability to create and edit color tables. #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metasim
force-pushed
the
feature/color-table
branch
8 times, most recently
from
44e6137 to
00d69f7
Compare
metasim
force-pushed
the
feature/color-table
branch
from
00d69f7 to
df79fbb
Compare
an existing file, which seems to have race-condition issues on Linux.
metasim
commented
Sep 29, 2022
metasim
commented
Sep 29, 2022
metasim
commented
Sep 29, 2022
metasim
commented
Sep 29, 2022
metasim
commented
Sep 29, 2022
metasim
commented
Sep 29, 2022
lnicola
reviewed
Oct 4, 2022
Co-authored-by: Laurențiu Nicola <[email protected]>
lnicola
reviewed
Oct 4, 2022
| end_index: u8, | ||
| end_color: &ColorEntry, | ||
| ) -> Result<ColorTable<'a>> { | ||
| if start_color.palette_interpretation() != end_color.palette_interpretation() { |
There was a problem hiding this comment.
I might be wrong, but it feels like this might just as well be an assert_eq!, since it's a user error to pass in different types of entries.
But it's fine to leave it like this, if there's prior art or you think it's more user-friendly.
There was a problem hiding this comment.
I lean toward not panic!-ing on behalf of the user whenever possible. If they want to unwrap and get a panic! that's their business, but rather give them the option to handle it more gracefully if they want.
There was a problem hiding this comment.
What I would have rather done is make it a compile error :) But that's a rabbit hole.
lnicola
reviewed
Oct 4, 2022
lnicola
reviewed
Oct 4, 2022
lnicola
approved these changes
Oct 4, 2022
Co-authored-by: Laurențiu Nicola <[email protected]>
|
bors r=lnicola |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.