Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to read into preallocated slice for rasterband #100

Merged
merged 2 commits into from
Oct 1, 2020
Merged

Ability to read into preallocated slice for rasterband #100

merged 2 commits into from
Oct 1, 2020

Conversation

rmanoka
Copy link
Contributor

@rmanoka rmanoka commented Oct 1, 2020

  • add read_into_slice
  • make read_as and read_as_array to use it
  • minor doc fixes
  • add test for read_into_slice

closes #82

@rmanoka
Ability to read into preallocated slice for rasterband
a682823 
+ add `read_into_slice`
+ make `read_as` and `read_as_array` to use it
+ minor doc fixes
+ add test for `read_into_slice`
@rmanoka rmanoka requested a review from jdroenner October 1, 2020 09:31
jdroenner
jdroenner approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@jdroenner jdroenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. could you resolve the merge conflict?

@rmanoka rmanoka merged commit dcf35c4 into master Oct 1, 2020
@ChristianBeilschmidt ChristianBeilschmidt deleted the rasterband-read-into-slice branch September 2, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdroenner jdroenner jdroenner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide read_into_slice ability in RasterBand
2 participants
@rmanoka @jdroenner