Obliterating most any reference to ORC #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should clean the code and fix issue georgmartius#95 Bug:georgmartius#95 Signed-off-by:Kalin KOZHUHAROV <[email protected]>
|
Hi @georgmartius, I know you are busy, but since nobody uses this part of the code and it causes issues, can we have it removed? And may be pimp a few other things and release something in 2024? |
|
Hi, thanks for investing time. Okay, I promise to do something on this repo in 1 month. Feel free to ping me again ;-). |
|
Hi @georgmartius, pinging you as requested ;-) Let's give this code a bit of love :-) |
|
Hi @georgmartius, re-pinging you... |
|
Sorry, I somehow misunderstood. This merge request looks good. Sure, let's get rid of some old stuff. |
|
If we require a version bump, please also prepare a pull request, I will then do that ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should clean the code and fix issue #95 ... I have completely forgotten it hangs on me for 4 years...
I did my best to make sure things work, but @georgmartius please have a look too, it was a lot more code to remove than I expected. If you are fine with all that, I think we can try to push a new version, so it can get packaged at some point.
It caused quite a stir at gentoo/gentoo#35264, since I have completely forgotten about this issue.
Bug: #95
Signed-off-by:Kalin KOZHUHAROV [email protected]
Related: https://bugs.gentoo.org/927886