feat: improve circle ci #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 84efe77.
|
What is the staging branch we are going to use? Can we set up the repo so that is the default? |
I think we can set up the rule once the new release is cut and when this is fully ready. Otherwise, it can impact other WIP PRs. |
|
Should be ready. With pip wheel cache enabled, CI runs under 5mins for an open PR. |
xzdandy
approved these changes
Aug 25, 2023
xzdandy
reviewed
Aug 25, 2023
jiashenC
force-pushed
the
improve-circle-ci
branch
from
a2c67c2
to
284741f
Compare
aryan-rajoria
pushed a commit
that referenced
this pull request
Aug 27, 2023
Test folder reorg
```
test
|__ unit_tests
|__ integration_tests
|__ short
|__ long
```
For open PR, we will run unit tests and short integration tests.
Once it is merged to staging branch, we will run long integration tests
across different versions and with both ray disabled or enabled.
Once it passes, it will be merged to master, which will run full test
(unit tests + all integration tests) with different python version and
with both ray disabled and enabled.
The testing for open PR is now around 8 mins, but majority of it is
installing package. I plan to also add cache for that but it is not
really working now.
---------
Co-authored-by: xzdandy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test folder reorg
For open PR, we will run unit tests and short integration tests.
Once it is merged to staging branch, we will run long integration tests across different versions and with both ray disabled or enabled.
Once it passes, it will be merged to master, which will run full test (unit tests + all integration tests) with different python version and with both ray disabled and enabled.
The testing for open PR is now around 8 mins, but majority of it is installing package. I plan to also add cache for that but it is not really working now.