-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ludwig-based model train and tune support. #935
Merged
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
0312c7a
Revert "Revert "Fix benchmark documentation (#931)""
xzdandy b1c2dc2
Merge branch 'master' of github.com:georgia-tech-db/eva
xzdandy 4d888e5
Ludwig based model train and tune support
xzdandy 1eb6dcd
LINTER
xzdandy 5554e08
LINTER
xzdandy 98d7119
LINTER
xzdandy 92d3030
Fix test
xzdandy d0f4f75
Fix test
xzdandy 2d46ac6
remove print
xzdandy aec2ae9
refactor binder for binded column for child select
xzdandy f4a8f66
LINTER
xzdandy 3aee0e6
pydantic conflict with ray
xzdandy 6be7e2b
Handle inputs and outputs column definition for ludwig UDFs
xzdandy 5b73d5a
LINTER
xzdandy 2937c05
Integration test for model train
xzdandy 911450a
Merge branch 'master' of github.com:georgia-tech-db/eva
xzdandy d84edc4
Merge branch 'master' into model_train
xzdandy 19de275
Fix parser for CREATE UDF TYPLE Ludwig
xzdandy 4f2e20b
Fix setup dependency for ludwig
xzdandy 4a6890f
Fix optimizer for CREATE UDF FROM SELECT
xzdandy 31e619d
Fix parser
xzdandy c6fa2eb
Fix test rule
xzdandy cab3c24
Fix column name
xzdandy 99deaca
Add ludwig skip marker for tests
xzdandy 8b97b86
Fix drop column alias
xzdandy fa93665
Merge branch 'master' of github.com:georgia-tech-db/eva
xzdandy a99cfdb
Merge branch 'master' into model_train
xzdandy 97c2dac
Try enable ludwig test for all non ray test on circlci.
xzdandy 70ab989
Fix circle ci config
xzdandy 03edea1
Add documentation for model training
xzdandy a102550
Try fix the dependency conflict in circle ci
xzdandy 2d8375a
Fix typo
xzdandy 2a4dc3d
Modify the yaml after installtion
xzdandy 1afa076
Remove old config
xzdandy 8d38fe7
Skip the native executor test and skip ludwig and ray for python3.1
xzdandy 35eadce
Try fix the inconsistent LINTER between local and circle ci
xzdandy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gaurav274 @jiashenC @jarulraj To avoid dependency conflict, I have changed the way that circle ci installs the EvaDB. Let me know if you have a different idea. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with this as well. Another way to rewrite this using the current infrastructure is when the ray is disabled and the python version is not 3.11. We already have both of those flags. If I understand correctly, we just need to combine https://github.com/georgia-tech-db/evadb/blob/master/.circleci/config.yml#L168 and https://github.com/georgia-tech-db/evadb/blob/master/.circleci/config.yml#L181?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not able to find a way to do
when else
in circle ci. I am following the suggestions from https://discuss.circleci.com/t/conditional-steps-if-else-without-code-duplication/45030There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am thinking of the following logic.
We can use nested logic https://circleci.com/docs/configuration-reference/#logic-statements to specify
ray disabled
andpython != 3.11
in one when statement. Will this work?