Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate to sqlalchemy 2.0 #908

Merged
merged 11 commits into from
Jun 28, 2023
Merged

feat: migrate to sqlalchemy 2.0 #908

merged 11 commits into from
Jun 28, 2023

Conversation

gaurav274
Copy link
Member

No description provided.

@jarulraj
Copy link
Member

Is it a good idea to keep the old code and do a version check for sqlalchemy? Have most packages moved to 2.0?

@gaurav274
Copy link
Member Author

Is it a good idea to keep the old code and do a version check for sqlalchemy? Have most packages moved to 2.0?

I tested with the older version of sqlalchemy. It works so we should be good.

@jarulraj jarulraj merged commit ac1eb58 into master Jun 28, 2023
@jarulraj jarulraj deleted the sqlalchemy2 branch June 28, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarulraj jarulraj jarulraj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaurav274 @jarulraj