Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Notebook and Ray testcases at staging #1274

Merged
merged 7 commits into from
Oct 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions test/integration_tests/long/test_open.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,4 +77,7 @@ def test_open_should_open_image(self):
{"testopentable.num": [1, 2], "open.data": [expected_img, expected_img]}
)
)
# We need sort. With ray enabled, the order is not guaranteed.
batch_res.sort_orderby(by=["testopentable.num"])
expected_batch.sort_orderby(by=["testopentable.num"])
self.assertEqual(expected_batch, batch_res)
3 changes: 3 additions & 0 deletions test/integration_tests/long/test_reuse.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@ def _verify_reuse_correctness(self, query, reuse_batch):
self.evadb, query, plan_generator=custom_plan_generator
)

self.assertEqual(reuse_batch.columns, reuse_batch.columns)
reuse_batch.sort_orderby(by=[reuse_batch.columns[0]])
without_reuse_batch.sort_orderby(by=[reuse_batch.columns[0]])
# printing the batches so that we can see the mismatch in the logs
self.assertEqual(
without_reuse_batch,
Expand Down
901 changes: 582 additions & 319 deletions tutorials/01-mnist.ipynb

Large diffs are not rendered by default.

Loading