Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Configuration Manager Redesign #1259

Closed

Conversation

hershd23
Copy link
Contributor

@hershd23 hershd23 commented Oct 6, 2023

Partially solves #1140
Adding EvaDb changes to the catalog

	modified:   evadb/catalog/catalog_manager.py
	new file:   evadb/catalog/models/configuration_catelog.py
	modified:   evadb/catalog/models/utils.py
	new file:   evadb/catalog/services/configuration_catalog_service.py
	modified:   evadb/catalog/sql_config.py

Adding EvaDB base configs to a python dict

	new file:   evadb/eva_config.py

@hershd23
Copy link
Contributor Author

hershd23 commented Oct 6, 2023

Up for an early review, still in WIP

@hershd23
Copy link
Contributor Author

hershd23 commented Oct 6, 2023

def catalog(self) -> "CatalogManager":

@gaurav274 @xzdandy there is one dependency issue that I see with config. The problem with initializaing config as a table in catalog is because catalog itself depends on config as you can see in the method above. Any suggestions on what to do in order to remove this?

@xzdandy xzdandy linked an issue Oct 6, 2023 that may be closed by this pull request
5 tasks
@xzdandy
Copy link
Collaborator

xzdandy commented Oct 6, 2023

def catalog(self) -> "CatalogManager":

@gaurav274 @xzdandy there is one dependency issue that I see with config. The problem with initializaing config as a table in catalog is because catalog itself depends on config as you can see in the method above. Any suggestions on what to do in order to remove this?

At the first glance, I think we need to decouple the catalog and configuration manager.

  1. Move catalog_database_uri out of config, since it can not be changed once a evadb instance is created.
  2. After we move the catalog_database_uri out of config, we than no longer need to pass config into catalog. So we can initialize all catalog tables (including the new configuration_catalog) in the catalog manager.

@hershd23
Copy link
Contributor Author

hershd23 commented Oct 6, 2023

@xzdandy I think the dependency doesn't end there, I saw a few more examples of the dependencies.

Will add more examples here.

Have parked this at this stage and will make sweeping changes today

service + utils
	modified:   evadb/catalog/catalog_manager.py
	modified:   evadb/catalog/catalog_utils.py
	new file:   evadb/catalog/models/configuration_catalog.py
	modified:   evadb/catalog/models/utils.py
	new file:   evadb/catalog/services/configuration_catalog_service.py
	modified:   evadb/catalog/sql_config.py
Base config changes for boothstrapping
	modified:   evadb/configuration/bootstrap_environment.py
	modified:   evadb/database.py
	new file:   evadb/evadb_config.py
	modified:   evadb/utils/generic_utils.py
@gaurav274
Copy link
Member

Moved to #1272

@gaurav274 gaurav274 closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration Manager Redesign
3 participants