-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Configuration Manager Redesign #1259
Conversation
Up for an early review, still in WIP |
Line 35 in 6208079
@gaurav274 @xzdandy there is one dependency issue that I see with config. The problem with initializaing config as a table in catalog is because catalog itself depends on config as you can see in the method above. Any suggestions on what to do in order to remove this? |
At the first glance, I think we need to decouple the catalog and configuration manager.
|
@xzdandy I think the dependency doesn't end there, I saw a few more examples of the dependencies. Will add more examples here. Have parked this at this stage and will make sweeping changes today |
service + utils modified: evadb/catalog/catalog_manager.py modified: evadb/catalog/catalog_utils.py new file: evadb/catalog/models/configuration_catalog.py modified: evadb/catalog/models/utils.py new file: evadb/catalog/services/configuration_catalog_service.py modified: evadb/catalog/sql_config.py Base config changes for boothstrapping modified: evadb/configuration/bootstrap_environment.py modified: evadb/database.py new file: evadb/evadb_config.py modified: evadb/utils/generic_utils.py
f123b6f
to
f42df11
Compare
Moved to #1272 |
Partially solves #1140
Adding EvaDb changes to the catalog
Adding EvaDB base configs to a python dict