Remove table names from column names for df() call
#1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzdandy
approved these changes
Oct 6, 2023
|
No merge now. Making minor changes to PR. |
2 tasks
a0x8o
pushed a commit
to alexxx-db/eva
that referenced
this pull request
Oct 30, 2023
…#1256) Removing table names from the `dataframe` during `df()` call. The users can then easily load CSV files generated using `EvaDB` with the `to_csv()` call at a later time (for long-running or expensive queries). Example: ``` select_query = cursor.query( f"SELECT * FROM {repo_name}_StargazerList;" ).df() select_query.to_csv("stargazers_list.csv", index=False) # Later cursor.query( f""" CREATE TABLE IF NOT EXISTS {repo_name}_StargazerList( github_username TEXT(1000)); """ ).df() cursor.query("LOAD CSV 'stargazers_list.csv' INTO {repo_name}_StargazerList;""").df() ``` Do we need the table names for any use cases? For example, for duplicate column names from two different functions - `object_detector_1.labels` and `object_detector_2.labels`? --------- Co-authored-by: Andy Xu <[email protected]> Co-authored-by: Andy Xu <[email protected]>
a0x8o
pushed a commit
to alexxx-db/eva
that referenced
this pull request
Nov 22, 2023
…#1256) Removing table names from the `dataframe` during `df()` call. The users can then easily load CSV files generated using `EvaDB` with the `to_csv()` call at a later time (for long-running or expensive queries). Example: ``` select_query = cursor.query( f"SELECT * FROM {repo_name}_StargazerList;" ).df() select_query.to_csv("stargazers_list.csv", index=False) cursor.query( f""" CREATE TABLE IF NOT EXISTS {repo_name}_StargazerList( github_username TEXT(1000)); """ ).df() cursor.query("LOAD CSV 'stargazers_list.csv' INTO {repo_name}_StargazerList;""").df() ``` Do we need the table names for any use cases? For example, for duplicate column names from two different functions - `object_detector_1.labels` and `object_detector_2.labels`? --------- Co-authored-by: Andy Xu <[email protected]> Co-authored-by: Andy Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing table names from the
dataframeduringdf()call. The users can then easily load CSV files generated usingEvaDBwith theto_csv()call at a later time (for long-running or expensive queries).Example:
Do we need the table names for any use cases? For example, for duplicate column names from two different functions -
object_detector_1.labelsandobject_detector_2.labels?