Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create index from projection #1244

Merged
merged 8 commits into from
Oct 2, 2023
Merged

feat: create index from projection #1244

merged 8 commits into from
Oct 2, 2023

Conversation

jiashenC
Copy link
Member

@jiashenC jiashenC commented Sep 30, 2023

The first step to do automatic index updates on insertions.

Replace the old version of creating an index, which directly reads data from the storage engine.

It now reads data from the children's plans: SeqScan and Storage.

@xzdandy
Copy link
Collaborator

xzdandy commented Oct 1, 2023

The design looks good. For record, the plan we are creating is CREATE_INDEX - PROJECTION - GET.

@xzdandy xzdandy added Optimizations Features/Bugs related to optimizations Feature Request ✨ New feature or request labels Oct 1, 2023
@xzdandy xzdandy added this to the v0.3.8 milestone Oct 1, 2023
@gaurav274
Copy link
Member

gaurav274 commented Oct 2, 2023

The first step to do automatic index updates on insertions.

I might be missing something, but I could not understand how "automatic index updates" is done in the code.
Ignore: understood, looked at your other PR.

@jiashenC jiashenC merged commit 277161e into staging Oct 2, 2023
7 checks passed
@jiashenC jiashenC deleted the vector-index-insert branch October 2, 2023 15:07
jiashenC added a commit that referenced this pull request Oct 4, 2023
Break the feature into multiple PRs. 

We can merge this PR after
#1244.
a0x8o pushed a commit to alexxx-db/eva that referenced this pull request Oct 30, 2023
The first step to do automatic index updates on insertions.

Replace the old version of creating an index, which directly reads data
from the storage engine.

It now reads data from the children's plans: SeqScan and Storage.
a0x8o pushed a commit to alexxx-db/eva that referenced this pull request Oct 30, 2023
Break the feature into multiple PRs.

We can merge this PR after
georgia-tech-db#1244.
a0x8o pushed a commit to alexxx-db/eva that referenced this pull request Oct 30, 2023
The first step to do automatic index updates on insertions.

Replace the old version of creating an index, which directly reads data
from the storage engine.

It now reads data from the children's plans: SeqScan and Storage.
a0x8o pushed a commit to alexxx-db/eva that referenced this pull request Oct 30, 2023
Break the feature into multiple PRs.

We can merge this PR after
georgia-tech-db#1244.
a0x8o pushed a commit to alexxx-db/eva that referenced this pull request Nov 22, 2023
The first step to do automatic index updates on insertions.

Replace the old version of creating an index, which directly reads data
from the storage engine.

It now reads data from the children's plans: SeqScan and Storage.
a0x8o pushed a commit to alexxx-db/eva that referenced this pull request Nov 22, 2023
Break the feature into multiple PRs.

We can merge this PR after
georgia-tech-db#1244.
a0x8o pushed a commit to alexxx-db/eva that referenced this pull request Nov 22, 2023
The first step to do automatic index updates on insertions.

Replace the old version of creating an index, which directly reads data
from the storage engine.

It now reads data from the children's plans: SeqScan and Storage.
a0x8o pushed a commit to alexxx-db/eva that referenced this pull request Nov 22, 2023
Break the feature into multiple PRs.

We can merge this PR after
georgia-tech-db#1244.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request ✨ New feature or request Optimizations Features/Bugs related to optimizations
Projects
Development

Successfully merging this pull request may close these issues.

3 participants