feat: create table in integration table from evadb select query #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Converting to lowercase for the time being. Changing the binder to take care of case sensitive databases is a long commitment and we can revisit it later.
gaurav274
added
Feature Request ✨
xzdandy
reviewed
Sep 14, 2023
| """USE test_data_source { | ||
| DROP TABLE IF EXISTS derived_table | ||
| }""", | ||
| ) |
There was a problem hiding this comment.
Is the clean up code? If so, shall we put it in the cls teardown?
There was a problem hiding this comment.
I agree. The test class is getting complicated and needs to be simplified.
xzdandy
reviewed
Sep 14, 2023
jiashenC
reviewed
Sep 15, 2023
| "DATETIME": datetime.datetime, | ||
| } | ||
|
|
||
| def preprocess_sqlite_type(sqlite_type): |
There was a problem hiding this comment.
What will be the format of sqlite_type passed in?
There was a problem hiding this comment.
I don't need a separate local function anymore. I can directly call the split on the input of the outer function.
| @@ -146,3 +151,45 @@ def execute_native_query(self, query_string: str) -> DBHandlerResponse: | |||
| return DBHandlerResponse(data=self._fetch_results_as_df(cursor)) | |||
| except sqlite3.Error as e: | |||
| return DBHandlerResponse(data=None, error=str(e)) | |||
|
|
|||
| def _sqlite_to_python_types(self, sqlite_type: str): | |||
| mapping = { | |||
There was a problem hiding this comment.
You probably already explained once, but why don't we directly map to ColumnType?
And, how do we handle types that are not part of our ColumnType (e.g., DATETIME)?
There was a problem hiding this comment.
- Don't want to expose EvaDB types to third-party integrations.
- We don't support it right now.
xzdandy
approved these changes
Sep 15, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CREATE TABLE postgres_db.table AS SELECT ...native_storage_enginetosqlalchemy