-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: third-party test #1124
fix: third-party test #1124
Conversation
Temporarily enable third party tests to ensure CI passes. But, I think we should maybe enable one |
@@ -38,7 +38,7 @@ def _create_table_in_native_database(self): | |||
"""USE test_data_source { | |||
CREATE TABLE test_table ( | |||
name VARCHAR(10), | |||
Age INT, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I intentionally made this change so that we could test the corner case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I missed that. Thanks for point it out.
How about |
e09ac50
to
858f74c
Compare
script/test/test.sh
Outdated
print_error_code $code "FULL TEST" | ||
} | ||
|
||
no_coverage_full_test() { | ||
PYTHONPATH=./ python -m pytest -p no:cov test/ -m "not benchmark" --ignore=test/third_party_tests/ --ignore=test/app_tests/ | ||
PYTHONPATH=./ python -m pytest -p no:cov test/ test/third_party_tests/test_native_executor.py::NativeExecutorTest::test_should_run_query_in_sqlite-m "not benchmark" --ignore=test/third_party_tests/ --ignore=test/app_tests/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we missing a space here? ... _in_sqlite-m
Also is MySQL CI running fine now? |
mysql
case sensitivity issue.sqlalchemy
uri for each database.