feat: UDF migrates to Function #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Cover migration in the code base, but also need some help to double-check migration on the documentation. |
|
This may also break the link in documentations and tutorials (example: https://github.com/georgia-tech-db/evadb/blob/staging/tutorials/03-emotion-analysis.ipynb). We need to double check. |
jarulraj
approved these changes
Sep 4, 2023
jiashenC
force-pushed
the
1009-migrate-from-create-udf-to-create-function
branch
from
f9b01fb
to
d83398e
Compare
xzdandy
requested changes
Sep 5, 2023
There was a problem hiding this comment.
Thanks for the efforts! Doc failures on current staging are fixed in #1035.
Verified on python3.10
- Notebook: 11-similarity-search-for-motif-mining.ipynb. The path needs to be fixed.
FAILED tutorials/11-similarity-search-for-motif-mining.ipynb:: - ExecutorError: Error creating UDF: Couldn't load UDF from /home/zxu330/eva/tutorials/../evadb/udfs/sift_feature_extractor.py : [Errno 2] No such file or directory: '/home/zxu330/eva/evadb/udfs/sift_feature_extractor.py'. This might be due to a missing Python package, or because the UDF implementation file does not exist, or it is not a valid Python file.
- Long integration tests
FAILED test/integration_tests/long/test_model_train.py::ModelTrainTests::test_ludwig_automl - evadb.executor.executor_utils.ExecutorError: No best trial found. Please check if you specified the correct default metric (metric_...
FAILED test/integration_tests/long/test_pytorch.py::PytorchTest::test_should_run_pytorch_and_asl - evadb.executor.executor_utils.ExecutorError: [Errno 2] No such file or directory: '/home/zxu330/eva/evadb/functions/asl_20_actions_...
#1036 created for test/integration_tests/long/test_model_train.py, and the failure is probably not relevant to this pr.
jiashenC
force-pushed
the
1009-migrate-from-create-udf-to-create-function
branch
from
fb49182
to
c49193e
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
xzdandy
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.