-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: UDF migrates to Function #1034
feat: UDF migrates to Function #1034
Conversation
Cover migration in the code base, but also need some help to double-check migration on the documentation. |
This may also break the link in documentations and tutorials (example: https://github.com/georgia-tech-db/evadb/blob/staging/tutorials/03-emotion-analysis.ipynb). We need to double check. |
f9b01fb
to
d83398e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the efforts! Doc failures on current staging are fixed in #1035.
Verified on python3.10
- Notebook: 11-similarity-search-for-motif-mining.ipynb. The path needs to be fixed.
FAILED tutorials/11-similarity-search-for-motif-mining.ipynb:: - ExecutorError: Error creating UDF: Couldn't load UDF from /home/zxu330/eva/tutorials/../evadb/udfs/sift_feature_extractor.py : [Errno 2] No such file or directory: '/home/zxu330/eva/evadb/udfs/sift_feature_extractor.py'. This might be due to a missing Python package, or because the UDF implementation file does not exist, or it is not a valid Python file.
- Long integration tests
FAILED test/integration_tests/long/test_model_train.py::ModelTrainTests::test_ludwig_automl - evadb.executor.executor_utils.ExecutorError: No best trial found. Please check if you specified the correct default metric (metric_...
FAILED test/integration_tests/long/test_pytorch.py::PytorchTest::test_should_run_pytorch_and_asl - evadb.executor.executor_utils.ExecutorError: [Errno 2] No such file or directory: '/home/zxu330/eva/evadb/functions/asl_20_actions_...
#1036 created for test/integration_tests/long/test_model_train.py, and the failure is probably not relevant to this pr.
fb49182
to
c49193e
Compare
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
No description provided.