feat: add CI for MySQL #1019
Merged
feat: add CI for MySQL #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I will move the CI to |
Closed
2 tasks
gaurav274
reviewed
Sep 1, 2023
| return mapping[mysql_type] | ||
| else: | ||
| raise Exception( | ||
| f"Unsupported column {mysql_type} encountered in the mysql table. Please raise a feature request!" |
There was a problem hiding this comment.
Can you also add the link to our Slack in this message (https://evadb.ai/community)?
There was a problem hiding this comment.
Add self.connection = None in the base class. Else it throws property not found in some cases.
There was a problem hiding this comment.
What do you mean by the link?
gaurav274
reviewed
Sep 1, 2023
| @@ -186,10 +186,6 @@ def test_should_run_query_in_mysql(self): | |||
| self._execute_native_query() | |||
| self._execute_evadb_query() | |||
|
|
|||
| # Test error. | |||
| self._raise_error_on_multiple_creation() | |||
There was a problem hiding this comment.
This test is actually invariant on which database engine we use. I currently just test on Postgres, so we should skip here.
| return mapping[mysql_type] | ||
| else: | ||
| raise Exception( | ||
| f"Unsupported column {mysql_type} encountered in the mysql table. Please raise a feature request!" |
There was a problem hiding this comment.
Add self.connection = None in the base class. Else it throws property not found in some cases.
xzdandy
approved these changes
Sep 1, 2023
jiashenC
force-pushed
the
add-ci-for-mysql
branch
from
7c0d5d5
to
634567f
Compare
jiashenC
force-pushed
the
add-ci-for-mysql
branch
from
634567f
to
f70592b
Compare
hershd23
pushed a commit
to hershd23/evadb
that referenced
this pull request
Sep 4, 2023
Co-authored-by: Rohith Mulumudy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.