-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: create Table fails when projecting column from native table #1007
Conversation
mod = dynamic_import(engine) | ||
except ImportError: | ||
req_file = os.path.join( | ||
"evadb", "third_party", "databases", engine, "requirements.txt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this path accessible if user directly installs from pip instead of source?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I realize this path will only work for dev testing. We should switch using absolute path. In addition, we also need to package requirements.txt
.
Reference to my closed PR: https://github.com/georgia-tech-db/evadb/pull/1001/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just add a new property function to the handler that returns the list of package. No need to worry about path .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We won't be able to import the class to access the property function.
get_columns
also returns the column datatypes