Drop quotes for UDF metadata

[xzdandy]

Search before asking

• I have searched the EvaDB issues and found no similar feature requests.

Description

Instead of currently

CREATE UDF IF NOT EXISTS PredictHouseRent FROM
( SELECT * FROM HomeRentals )
TYPE Ludwig
'predict' 'rental_price'
'time_limit' 120;

We'd like to move to

CREATE UDF IF NOT EXISTS PredictHouseRent FROM
( SELECT * FROM HomeRentals )
TYPE Ludwig
PREDICT rental_price
TIME_LIMIT 120;

Use case

No response

Are you willing to submit a PR?

• Yes I'd like to help by submitting a PR!

[hershd23]

Hi can I take this up?

[gaurav274]

Sure!

[hershd23]

Hi regarding this issue.

I went through files in the parser as well as the final statement_binder evadb/binder/statement_binder.py . I see that predict right now is being added in UDF metadata

evadb/evadb/parser/lark_visitor/_functions.py

Line 93 in 8aa807b

elif child.data == "udf_metadata":

My question is whether I need to move PREDICT to a predicate or let it be in the metadata

[xzdandy]

Hi regarding this issue.

I went through files in the parser as well as the final statement_binder evadb/binder/statement_binder.py . I see that predict right now is being added in UDF metadata

evadb/evadb/parser/lark_visitor/_functions.py

Line 93 in 8aa807b

elif child.data == "udf_metadata":

My question is whether I need to move PREDICT to a predicate or let it be in the metadata

Hi Hersh, the PREDICT should be in the metadata.

[hershd23]

Hi came across this line in the lark file

evadb/evadb/parser/evadb.lark

Line 38 in 94e17a9

create_udf: CREATE UDF if_not_exists? udf_name INPUT create_definitions OUTPUT create_definitions TYPE udf_type IMPL udf_impl udf_metadata*

Where udf_metadata is described as

udf_metadata: udf_metadata_key udf_metadata_value

udf_metadata_key: string_literal

udf_metadata_value: string_literal | decimal_literal

I don't think changing the string_literal definition would solve this since it is used everywhere for filepaths etc.

    def string_literal(self, tree):
        text = tree.children[0]
        assert text is not None
        return ConstantValueExpression(text[1:-1], ColumnType.TEXT)

I am thinking I need to create a different expression for this and not define PREDICT and TIME_LIMIT as string literals. Can you give me a few pointers here @xzdandy

[xzdandy]

I saw in your pr you have used uid instead of string_literal. Is this still a problem?

[hershd23]

No no, I just wanted to link the issue to the PR. That's it. Making it a UID solves the problem

[hershd23]

Closed as #1026 has been merged into staging