Skip to content

Commit

Permalink
ESQL: Add skips to tests that were added retroactively (elastic#114727)
Browse files Browse the repository at this point in the history
Skip some csv tests that cannot be used in bwc tests before 8.13/8.14.
  • Loading branch information
alex-spies authored and georgewallace committed Oct 25, 2024
1 parent 28c9d18 commit 06f83b2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ date1:date | dd_ms:integer
2023-12-02T11:00:00.000Z | 1000
;

evalDateDiffMonthAsWhole0Months
evalDateDiffMonthAsWhole0Months#[skip:-8.14.1, reason:omitting millis/timezone not allowed before 8.14]

ROW from=TO_DATETIME("2023-12-31T23:59:59.999Z"), to=TO_DATETIME("2024-01-01T00:00:00")
| EVAL msecs=DATE_DIFF("milliseconds", from, to), months=DATE_DIFF("month", from, to)
Expand All @@ -378,7 +378,7 @@ ROW from=TO_DATETIME("2023-12-31T23:59:59.999Z"), to=TO_DATETIME("2024-01-01T00:

;

evalDateDiffMonthAsWhole1Month
evalDateDiffMonthAsWhole1Month#[skip:-8.14.1, reason:omitting millis/timezone not allowed before 8.14]

ROW from=TO_DATETIME("2023-12-31T23:59:59.999Z"), to=TO_DATETIME("2024-02-01T00:00:00")
| EVAL secs=DATE_DIFF("seconds", from, to), months=DATE_DIFF("month", from, to)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ null |Swan |-8.46 |-8.46
Sanjiv |Zschoche |[-7.67, -3.25] |[-3.25, -7.67] |[-3, -8] |10053
;

sortingOnSwappedFields
sortingOnSwappedFields#[skip:-8.13.3, reason:fixed in 8.13]
FROM employees
| EVAL name = last_name, last_name = first_name, first_name = name
| WHERE first_name > "B" AND last_name IS NOT NULL
Expand All @@ -157,7 +157,7 @@ Brattka | Charlene | Brattka
Bridgland | Patricio | Bridgland
;

sortingOnSwappedFieldsNoKeep
sortingOnSwappedFieldsNoKeep#[skip:-8.13.3, reason:fixed in 8.13]
// Note that this test requires all fields to be returned in order to test a specific code path in physical planning
FROM employees
| EVAL name = first_name, first_name = last_name, last_name = name
Expand Down

0 comments on commit 06f83b2

Please sign in to comment.