Skip to content

Commit

Permalink
feat: make video embeddings optional. (alshedivat#2337)
Browse files Browse the repository at this point in the history
As discussed in alshedivat#1181, I suggest to make embedding videos an optional
feature.

This behavior aligns well with recently merged PR alshedivat#2312.

Open questions:

1. I added a youtube link to `papers.bib`. Is this link okay?
2. I set `enable_video_embedding: false` as the default. I argue that
privacy settings should be the default. Also, the current implementation
of `video.liquid` only works for some very specific video URLs. For
example, to embed youtube, specialized links must be used to avoid
`X-Frame-Option` issues. This behavior can lead to a broken embedding,
which would not look very nice.

Feedback welcome.
  • Loading branch information
CheariX authored and george-gca committed Apr 15, 2024
1 parent 96e6159 commit d0d6002
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
3 changes: 1 addition & 2 deletions _bibliography/papers.bib
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,8 @@ @article{PhysRev.47.777
altmetric={248277},
dimensions={true},
google_scholar_id={qyhmnyLat1gC},
video={https://www.youtube-nocookie.com/embed/aqz-KE-bpKQ},
additional_info={. *More Information* can be [found here](https://github.com/alshedivat/al-folio/)},
acceptance={9/123},
acceptance_rate={7\%},
selected={true}
}

Expand Down
1 change: 1 addition & 0 deletions _config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,7 @@ enable_navbar_social: false # enables displaying social links in the navbar on t
enable_project_categories: true # enables categorization of projects into multiple categories
enable_medium_zoom: true # enables image zoom feature (as on medium.com)
enable_progressbar: true # enables a horizontal progress bar linked to the vertical scroll position
enable_video_embedding: false # enables video embedding for bibtex entries. If false, the button opens the video link in a new window.

# -----------------------------------------------------------------------------
# Library versions
Expand Down
6 changes: 4 additions & 2 deletions _layouts/bib.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,10 @@
<a href="{{ entry.supp | prepend: '/assets/pdf/' | relative_url }}" class="btn btn-sm z-depth-0" role="button">Supp</a>
{% endif %}
{% endif %}
{% if entry.video %}
{% if entry.video and site.enable_video_embedding %}
<a class="abstract btn btn-sm z-depth-0" role="button">Video</a>
{% elsif entry.video %}
<a href="{{ entry.video }}" class="btn btn-sm z-depth-0" role="button">Video</a>
{% endif %}
{% if entry.blog %}
<a href="{{ entry.blog }}" class="btn btn-sm z-depth-0" role="button">Blog</a>
Expand Down Expand Up @@ -307,7 +309,7 @@
</div>
{% endif %}

{% if entry.video %}
{% if entry.video and site.enable_video_embedding %}
<!-- Hidden video block -->
<div class="abstract hidden">
<div style="text-align: center;">{% include video.liquid path=entry.video class="img-fluid rounded z-depth-1" controls=true %}</div>
Expand Down

0 comments on commit d0d6002

Please sign in to comment.