Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a native git provider #9

Closed
helpermethod opened this issue Jan 19, 2020 · 6 comments
Closed

Implement a native git provider #9

helpermethod opened this issue Jan 19, 2020 · 6 comments
Milestone
0.7.0

Comments

@helpermethod
Copy link
Collaborator

helpermethod commented Jan 19, 2020 •
edited
Loading

The project currently uses jgit for creating branches, committing modifications, pushing refs, etc... .

While jgit offers some benefits (Java-based DSL, does not require a native git client) it requires extensive setup for authenticating against a remote repository, which may be acceptable in Docker-based CI environments but not so in non-Docker based environments (Jenkins without Docker agent, local dev machine).

The goal of this ticket is to implement a git provider which uses the native git executable if present.
@helpermethod helpermethod mentioned this issue Jan 19, 2020
Closed
@sparsick
Copy link
Collaborator

Hi @helpermethod, if you are interested, @georgberky and me could contribute a proposal of an implementation for this feature.

@helpermethod
Copy link
Collaborator Author

helpermethod commented Mar 19, 2020 •
edited
Loading

Hi @sparsick!

That would be awesome!

sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue Mar 20, 2020
@sparsick @georgberky
georgberky#9: refactoring maven config
31336b6 
- simplify local build
- move release relevant steps to own profile

Co-authored-by: Georg Berky <[email protected]>
georgberky added a commit to sparsick/dependency-update-maven-plugin that referenced this issue Mar 20, 2020
@georgberky @sparsick
georgberky#9 Add JUnit and AssertJ
6760311 
Co-Authored-By: Sandra Parsick <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue Mar 20, 2020
@sparsick @georgberky
georgberky#9: extracting interface
dbf5071 
- move jgit specific operation to interface implementation

Co-authored-by: Georg Berky <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue Mar 21, 2020
@sparsick
georgberky#9: change junit jupiter deps
1d90987
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue Mar 21, 2020
@sparsick
georgberky#9: refacoring
e698c5d 
- use more kotlin syntax
@helpermethod
Copy link
Collaborator Author

Hi @sparsick,

because your commits already improve dependency-update-maven-plugin by a large margin, would you like to do a first PR?

The concrete implementation of the NativeGitProvider (or whatever you may call it) could be done in a separate PR.

What do you think?

@helpermethod
Copy link
Collaborator Author

BTW I've created a Slack channel to discuss ideas, further development, tooling and so on

https://join.slack.com/t/dependencyupd-pfm5382/shared_invite/zt-d34ieqlj-qk9T6YLmtYwaxFAAiY34kA

I will also add a badge to the README.me if time permits.

@sparsick
Copy link
Collaborator

Hi @helpermethod

because your commits already improve dependency-update-maven-plugin by a large margin,
would you like to do a first PR?

It is a good idea. Let me change the PR title and description and then you can go for it. @georgberky and I want to continue on Friday with the implementation.

sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue Mar 25, 2020
@sparsick
georgberky#9: refacoring
5f3c59b 
- use more kotlin syntax sugar
helpermethod pushed a commit that referenced this issue Mar 25, 2020
@sparsick @georgberky
Preparation for Native Git Provider (#10)
872f726 
* #9: refactoring maven config

- simplify local build
- move release relevant steps to own profile

Co-authored-by: Georg Berky <[email protected]>

* #9 Add JUnit and AssertJ

Co-Authored-By: Sandra Parsick <[email protected]>

* #9: extracting interface

- move jgit specific operation to interface implementation

Co-authored-by: Georg Berky <[email protected]>

* #9: change junit jupiter deps

* #9: refacoring

- use more kotlin syntax

* #9: refacoring

- use more kotlin syntax sugar

Co-authored-by: Georg Berky <[email protected]>
Co-authored-by: Georg Berky <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue Mar 27, 2020
@sparsick
georgberky#9: add invoker setup
5cae751 
- preparation for integration tests
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue Mar 27, 2020
@sparsick
georgberky#9: add test skeleton
4b9d52b 
- test is failing
georgberky added a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 20, 2020
@georgberky @sparsick
georgberky#9 add slf4j-simple for debugging output
35ce175 
Co-Authored-By: Sandra Parsick <[email protected]>
georgberky added a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 20, 2020
@georgberky @sparsick
georgberky#9 first test for add() in native git provider
066e385 
Co-Authored-By: Sandra Parsick <[email protected]>
georgberky added a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 20, 2020
@georgberky @sparsick
georgberky#9 add first test for commit() to native git provider
ed4fee1 
Co-Authored-By: Sandra Parsick <[email protected]>
georgberky added a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 20, 2020
@georgberky @sparsick
georgberky#9 refactor test for readability
f6556f3 
Co-Authored-By: Sandra Parsick <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue Jun 2, 2020
@sparsick @georgberky
georgberky#9: implementation of checkoutNewBranch
a4a827f 
Co-authored-by: Georg Berky <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue Jun 2, 2020
@sparsick @georgberky
georgberky#9: implementation of hasRemoteBranch
16f83b2 
Co-authored-by: Georg Berky <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue Jun 2, 2020
@sparsick @georgberky
georgberky#9: refactoring
82f87ea 
Co-authored-by: Georg Berky <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue Jun 9, 2020
@sparsick
georgberky#9: implement push and close
362da2a 
Co-authored-by: Georg Berky <[email protected]>
georgberky added a commit to sparsick/dependency-update-maven-plugin that referenced this issue Jun 9, 2020
@georgberky
georgberky#9 Refactoring: extract runInProcess/runInProcessWithOutput
f7d95c9 
 Co-Authored-By: Sandra Parsick <[email protected]>
georgberky added a commit to sparsick/dependency-update-maven-plugin that referenced this issue Jun 9, 2020
@georgberky
georgberky#9 start error handling tests
10c1c32 
 Co-Authored-By: Sandra Parsick <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue Jun 23, 2020
@sparsick
georgberky#9: error handling for checkout new branch
4eca817 
Co-authored-by: Georg Berky <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue Jun 23, 2020
@sparsick
georgberky#9: error handling for has remote branch
5480d69 
Co-authored-by: Georg Berky <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue Jun 23, 2020
@sparsick
georgberky#9: error handling for commit
2c12ac6 
Co-authored-by: Georg Berky <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue Jun 23, 2020
@sparsick
georgberky#9: error handling for push
71ec181 
Co-authored-by: Georg Berky <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue Jun 23, 2020
@sparsick
georgberky#9: configure jvmtarget to 1.8
32125da 
Co-authored-by: Georg Berky <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@georgberky @sparsick
georgberky#9 refactor test for readability
35e0229 
Co-Authored-By: Sandra Parsick <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@sparsick @georgberky
georgberky#9: implementation of checkoutNewBranch
25ccc73 
Co-authored-by: Georg Berky <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@sparsick @georgberky
georgberky#9: implementation of hasRemoteBranch
930a6b1 
Co-authored-by: Georg Berky <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@sparsick @georgberky
georgberky#9: refactoring
52cbfda 
Co-authored-by: Georg Berky <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@sparsick
georgberky#9: implement push and close
13e21fb 
Co-authored-by: Georg Berky <[email protected]>
sparsick pushed a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@georgberky @sparsick
georgberky#9 Refactoring: extract runInProcess/runInProcessWithOutput
d8221e2 
 Co-Authored-By: Sandra Parsick <[email protected]>
sparsick pushed a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@georgberky @sparsick
georgberky#9 start error handling tests
3b17d4c 
 Co-Authored-By: Sandra Parsick <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@sparsick
georgberky#9: error handling for checkout new branch
73f6679 
Co-authored-by: Georg Berky <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@sparsick
georgberky#9: error handling for has remote branch
6dfb8e3 
Co-authored-by: Georg Berky <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@sparsick
georgberky#9: error handling for commit
98a162d 
Co-authored-by: Georg Berky <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@sparsick
georgberky#9: error handling for push
2b45498 
Co-authored-by: Georg Berky <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@sparsick
georgberky#9: configure jvmtarget to 1.8
f924552 
Co-authored-by: Georg Berky <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@sparsick
georgberky#9: refactoring
57d0731 
Co-authored-by: Georg Berky <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@sparsick @georgberky
georgberky#9: find path to native git on unix-based system
2f186ab 
Co-authored-by: Georg Berky <[email protected]>
sparsick pushed a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@georgberky @sparsick
georgberky#9 add factory for git provider implementations
76269c5 
 Co-Authored-By: Sandra Parsick <[email protected]>
sparsick pushed a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@georgberky @sparsick
georgberky#9 WIP: add ITF integrated test for plugin
1921d47 
 - with native provider
 - still messy with Kotlin and class names

 Co-Authored-By: Sandra Parsick <[email protected]>
sparsick pushed a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@georgberky @sparsick
georgberky#9 initial integration test runs
bae42ed 
 Co-Authored-By: Sandra Parsick <[email protected]>
 Co-Authored-By: Karl Heinz Marbaise <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@georgberky @sparsick @khmarbaise
georgberky#9 WIP: integration test fails for the right reason
e4c0152 
Co-Authored-By: Sandra Parsick <[email protected]>
Co-Authored-By: Karl Heinz Marbaise <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@georgberky @sparsick
georgberky#9 WIP: ArtifactVersionComparisonTest
1bcd3a8 
Co-Authored-By: Sandra Parsick <[email protected]>
Co-Authored-By: Karl Heinz Marbaise <[email protected]>
                                                    u
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@georgberky @sparsick @khmarbaise
georgberky#9 update Java to 11
73d8fbb 
Co-Authored-By: Sandra Parsick <[email protected]>
Co-Authored-By: Karl Heinz Marbaise <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@khmarbaise @sparsick @georgberky
georgberky#9 Excluded dependency to junit 3.X
a4a4738 
Co-Authored-By: Sandra Parsick <[email protected]>
Co-Authored-By: Georg Berky <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@khmarbaise @sparsick @georgberky
georgberky#9 Downgrade to JDK 8.
4d9f69c 
Co-Authored-By: Sandra Parsick <[email protected]>
Co-Authored-By: Georg Berky <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@khmarbaise @sparsick @georgberky
georgberky#9 - Initial commit message.
b855eca 
   - The used directory from baseDirectory to targetProjectDirectory.
   - Using git init instead of git open.

Co-Authored-By: Sandra Parsick <[email protected]>
Co-Authored-By: Georg Berky <[email protected]>
sparsick pushed a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@georgberky @sparsick
georgberky#9 add exploratory tests for comparing versions
367bcdd 
 Co-Authored-By: Sandra Parsick <[email protected]>
 Co-Authored-By: Karl Heinz Marbaise <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@khmarbaise @sparsick @georgberky
georgberky#9 - WIP: git push does not work based on missing remote.
ce53a67 
Co-Authored-By: Sandra Parsick <[email protected]>
Co-Authored-By: Georg Berky <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@georgberky @sparsick @khmarbaise
georgberky#9 native git provider: creates feature branches
2a874b5 
Co-Authored-By: Sandra Parsick <[email protected]>
Co-Authored-By: Karl Heinz Marbaise <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@sparsick @khmarbaise
georgberky#9: update itf extension to 0.10.0
7ef050b 
Co-Authored-By: Karl Heinz Marbaise <[email protected]>
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue May 18, 2021
@sparsick @khmarbaise
georgberky#9: add git to drone setup
1e35b9a 
Co-Authored-By: Karl Heinz Marbaise <[email protected]>
@khmarbaise khmarbaise added this to the 0.7.0 milestone May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
3 participants
@khmarbaise @sparsick @helpermethod