#43 Rename canSkip to isAlreadyLatestVersion

- also use filterNot instead of negation in method
georgberky · Jul 7, 2022 · 3245fcf · 3245fcf
1 parent a3dad58
commit 3245fcf
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/main/kotlin/io/github/georgberky/maven/plugins/depsupdate/UpdateMojo.kt b/src/main/kotlin/io/github/georgberky/maven/plugins/depsupdate/UpdateMojo.kt
@@ -45,7 +45,7 @@ class UpdateMojo : AbstractMojo() {
             )
             .updates
             .onEach { println("execute im mojo: latestVersion: '${it.latestVersion}' / version:'${it.version}'") }
-            .filter(VersionUpdate::canSkip)
+            .filterNot (VersionUpdate::isAlreadyLatestVersion)
             .onEach { println("execute im mojo canSkip: ${it.latestVersion}") }
             .map { it to "dependency-update/${it.groupId}-${it.artifactId}-${it.latestVersion}" }
             .onEach { println("execute im mojo canSkip (nach map): ${it.second} ${it.first}") }
@@ -70,4 +70,4 @@ class UpdateMojo : AbstractMojo() {
         val git = gitProvider.createProvider(mavenProject.basedir.toPath(), settings, connection);
         git.use(f)
     }
-}
+}
diff --git a/src/main/kotlin/io/github/georgberky/maven/plugins/depsupdate/VersionUpdate.kt b/src/main/kotlin/io/github/georgberky/maven/plugins/depsupdate/VersionUpdate.kt
@@ -10,10 +10,10 @@ abstract class VersionUpdate(
 ) {
     abstract fun updatedPom() : Document
 
-    fun canSkip() : Boolean {
+    fun isAlreadyLatestVersion() : Boolean {
         println("canSkip: ${latestVersion} compare to ${version}")
         println("latestVersion.equals(version) = ${latestVersion.equals(version)}")
-        return !latestVersion.equals(version)
+        return latestVersion.equals(version)
     }
 
-}
+}