fix: select forest type only when clicking on select option

geops · Oct 2, 2020 · 6a257a6 · 6a257a6
1 parent 459cea2
commit 6a257a6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 11 deletions.
diff --git a/src/components/ForestTypeModal.js b/src/components/ForestTypeModal.js
@@ -23,14 +23,8 @@ function ForestTypeModal({ data, setIsForestTypeModalOpen }) {
           {data.la ? <i>{data.la}</i> : null}
         </Modal.Header>
       }
-      onClose={(e) => {
-        e.stopPropagation();
-        setIsForestTypeModalOpen(false);
-      }}
-      onOpen={(e) => {
-        e.stopPropagation();
-        setIsForestTypeModalOpen(true);
-      }}
+      onClose={(e) => setIsForestTypeModalOpen(false)}
+      onOpen={(e) => setIsForestTypeModalOpen(true)}
       trigger={<Button active icon="info" />}
     />
   );

diff --git a/src/components/LocationResult.js b/src/components/LocationResult.js
@@ -82,9 +82,11 @@ function LocationResult() {
                           }
                           key={key}
                           value={key}
-                          onClick={(e, { value: forestType }) =>
-                            selectForestType(forestType)
-                          }
+                          onClick={(e, { value: forestType }) => {
+                            if (e.target.getAttribute('role') === 'option') {
+                              selectForestType(forestType);
+                            }
+                          }}
                         />
                       );
                     })}