Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: silence warning from write_dataframe with GeoSeries.notna() #435

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Jun 26, 2024

Closes #432

Add TODO note to sort-out reading POINT EMPTY, which I'll open in a separate issue...

@mwtoews mwtoews force-pushed the fix-geoseries-notna-warning branch from db6161c to 24e1a88 Compare June 27, 2024 09:03
Copy link
Member

@brendan-ward brendan-ward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @mwtoews

Could you please add a changelog entry? Let's assume that the next version will be a bug fix release, 0.9.1.

pyogrio/tests/test_geopandas_io.py Outdated Show resolved Hide resolved
@brendan-ward brendan-ward merged commit d82974c into geopandas:main Jul 2, 2024
19 of 20 checks passed
@mwtoews mwtoews deleted the fix-geoseries-notna-warning branch July 2, 2024 17:58
@DevkumarPatel
Copy link

Hi any, updates on when this will be pushed out or released?

@brendan-ward
Copy link
Member

No specific date planned, but I'm hoping that we can push out an 0.9.1 release once we have the outstanding fix / cleanup PRs merged and another one I'm working on to cleanup test data files. Maybe within the next week?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserWarning from geopandas' to_file() with GeoSeries.notna()
3 participants