Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datahub: fine tuning #663

Merged
merged 9 commits into from
Nov 3, 2023
Merged

Datahub: fine tuning #663

merged 9 commits into from
Nov 3, 2023

Conversation

fgravin
Copy link
Member

@fgravin fgravin commented Oct 24, 2023

  • Colors, margins, markup, transition, hover, borders, duration etc...

See commit messages for more information.

For the color debate, I don't really care. The only thing that I would like is that the geo2france design is respected.
There are way many other inconsistencies in the geo2france page, like too lighter grays all over the place. I don't know what is the best strategy, if there is a contrast issue, we could change the main color for the default theme ? or ask a UI designer to work on a default theme maybe.
The last commit can be removed anyway.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

Affected libs: ui-catalog, feature-catalog, feature-record, feature-router, ui-dataviz, feature-dataviz, ui-search, feature-search, feature-map, ui-elements, ui-layout,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Collaborator

@Angi-Kinas Angi-Kinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes. I just found a minor thing.

@fgravin fgravin added the bug Something isn't working label Oct 25, 2023
@jahow jahow added this to the 2.1.0 milestone Oct 25, 2023
@coveralls
Copy link

coveralls commented Oct 31, 2023

Coverage Status

coverage: 86.67% (+3.6%) from 83.092%
when pulling 44f34f8 on org-scale
into 2901ae6 on main.

@fgravin
Copy link
Member Author

fgravin commented Oct 31, 2023

The branch have been rebased and is ready to merge.
It does not change the gray color behavior, the tuning on the gray is just about the figure panel and the feed record preview, which were not consistent with the UI and the rest of the application.

@fgravin fgravin requested a review from Angi-Kinas October 31, 2023 18:08
Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing all these visual details @fgravin !

libs/ui/dataviz/src/lib/figure/figure.component.spec.ts Outdated Show resolved Hide resolved
@@ -20,7 +20,7 @@
>
<div class="mb-3 mt-5 sm:mt-2">
<div
class="font-title text-21 text-title line-clamp-2 col-start-1 col-span-2 sm:line-clamp-1 group-hover:text-primary"
class="font-title text-21 text-title line-clamp-2 col-start-1 col-span-2 sm:line-clamp-1 group-hover:text-primary transition-colors"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The transition has not been applied to the feed preview, but I guess this is on purpose (as it already has the shadow transition and primary org title).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, I think it was from the mockup, but not sure

@fgravin fgravin merged commit 48ffc34 into main Nov 3, 2023
6 checks passed
@fgravin fgravin deleted the org-scale branch November 3, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants