Datahub: Fix display of ESRI data on map #652
Conversation
|
Affected libs:
|
| @@ -197,7 +197,10 @@ export class DataService { | |||
| link.type === 'service' && | |||
| link.accessServiceProtocol === 'esriRest' | |||
| ) { | |||
| const url = this.getDownloadUrlFromEsriRest(linkUrl, 'geojson') | |||
There was a problem hiding this comment.
Maybe the linkUrl was not explicit enough...
Should be linkProxifiedUrl, could have help to know to not use it, as getDownloadUrlFromEsriRest also proxifies the url.
By the way, I also see that in the same function, the call of getDownloadUrlsFromWfs also proxifies the URL twice, so to me, the codeflow within this method is confusing.
There was a problem hiding this comment.
Yep, true I'll rename it and see if I can improve more, like removing the double proxying for WFS, which does not cause errors right now thanks to ogc-client.
There was a problem hiding this comment.
Ok, I've adapted my previous commit accordingly.
…sure query params encoding otherwise first call encodes URL without query params and second call returns unmodified URL, since the host is already the window host for more clarity also prevents double proxification for WFS, that did not fail thanks to ogc-client
tkohr
force-pushed
the
esri-fix-data-url
branch
from
75afa40 to
446a63c
Compare
PR