Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeoJSON output updates to specification #77

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

GeoJSON output updates to specification #77

wants to merge 2 commits into from
+114 −9

Conversation

josegar74
Copy link
Member

No description provided.

@josegar74 josegar74 requested a review from fxprunayre April 27, 2023 16:18
@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fxprunayre
Copy link
Member

LGTM but some checkstyle warning @josegar74

[INFO] --- maven-checkstyle-plugin:3.1.1:check (check) @ gn-cloud-common-index-model ---
Warning:  src/main/java/org/fao/geonet/index/model/geojson/Address.java:[10] (imports) CustomImportOrder: Wrong lexicographical order for 'java.util.List' import. Should be before 'lombok.experimental.SuperBuilder'.

@fxprunayre fxprunayre added this to the 4.2.5 milestone May 10, 2023
@fxprunayre fxprunayre modified the milestones: 4.2.5-0, 4.2.6-0 Jul 7, 2023
@davidblasby
Copy link
Contributor

@josegar74 @fxprunayre - should this be merged?

@davidblasby
Copy link
Contributor

I had to git merge origin/main to get this branch to work (and -P-docker). I think its because its targeting an older version of GN that doesn't have this commit:

geonetwork/core-geonetwork@9675e13

git merge origin/main seemed to get it to work.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 16, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@CLAassistant
Copy link

CLAassistant commented Dec 8, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxprunayre fxprunayre fxprunayre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.2.6-0
Development

Successfully merging this pull request may close these issues.
4 participants
@josegar74 @fxprunayre @davidblasby @CLAassistant