Change GeoJSON to be used for f=json, add f=elastic-json for old format #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josegar74 @fxprunayre - I will merge this thursday (after the geojson changes). |
fxprunayre
reviewed
Oct 23, 2024
| @@ -55,5 +58,6 @@ public GnMediaType(String type) { | |||
| APPLICATION_GN_XML = new MediaType("application", "gn+xml"); | |||
| APPLICATION_JSON_LD = new MediaType("application", "ld+json"); | |||
| APPLICATION_GEOJSON = new MediaType("application", "geo+json"); | |||
| APPLICATION_ELASTICJSON = new MediaType("application", "elastic+json"); | |||
There was a problem hiding this comment.
Suggested change
| APPLICATION_ELASTICJSON = new MediaType("application", "elastic+json"); | |
| APPLICATION_ELASTICJSON = new MediaType("application", "gnindex+json"); |
maybe?
There was a problem hiding this comment.
thanks @fxprunayre - I've changed it to "gnindex+json".
Thanks for the review - its really really helpful!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OGCAPI-Records spec says to use GeoJSON for
/collections/<collectionId>/itemsand/collections/<collectionId>/items/<itemId>responses.This PR changes the current default (the underlying Elastic Search results) and, instead, uses GeoJSON.
I've also added a
f=elastic-jsonfor the old behaviour. This shouldn't be used, and will be removes in the future. However, I don't want to remove it now since people might be relying on it, and its useful for debugging.Also, see #118 for improvements to the GeoJSON output.