Harvester / Remove records by harvester UUID #8431
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When harvester contains lot of records, remove records take a while or could even return heapspace errors. Try to improve performances by using delete by query (instead of loop on each records) eg. 1500 records * Select > Delete all = 2min * Harvester > Remove records = 700ms This will bypass events but maybe that is fine for harvested records? Maybe there is better JPA alternative for this kind of query?
fxprunayre
force-pushed
the
feature/447-harvester-removerecords
branch
from
d151b55
to
2bad0f4
Compare
|
josegar74
reviewed
Oct 14, 2024
There was a problem hiding this comment.
Looks good and it's much faster.
Some considerations:
- Metadata harvested with the GeoNetwork ‘protocol’ in MEF format, may store files in the data directory. In this case, the files should be deleted also.
To check if other harvesters support the MEF format.
- If the setting
Allow editing on harvested recordsis enabled, the same problem will occur. Also, if the setting is enabled, it might make sense to use the original method to delete the metadata, which backs up the deleted metadata.
|
|
||
| default void deleteAllByHarvesterUuid(String harvesterUuid) { |
There was a problem hiding this comment.
What is the reason for defining it as the default method?
Indeed, also harvesting WMS most of the time produce thumbnails in the datadir. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When harvester contains lot of records, remove records take a while or could even return heapspace errors.
Try to improve performances by using delete by query (instead of loop on each records) eg. 1500 records
This will bypass events but maybe that is fine for harvested records?
Maybe there is better JPA alternative for this kind of query?
Checklist
mainbranch, backports managed with labelREADME.mdfilespom.xmldependency management. Update build documentation with intended library use and library tutorials or documentationFunded by Ifremer