-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration to display an application banner #8416
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One limitation is that the message is not multilingual. One option would be to use the service description of the catalogue like we do here https://github.com/geonetwork/core-geonetwork/blob/main/web-ui/src/main/resources/catalog/views/default/templates/home.html#L9 but not sure it worth it?
I was thinking to configure a translation-key in the database and use it. I'll check to update the pull request with this. |
yep maybe a translation key can be good enough and will be display in main catalogue and portal more easily. |
@fxprunayre updated to use a translation key |
@josegar74 I had a go at the styling and looked at how GitHub did it. I used the same yellow background for a better contrast of background and foreground. For now the text is always displayed as This is the .application-banner {
background-color: #fff8c5;
border: 1px solid #d4a72c66;
margin: 15px;
padding: 15px;
border-radius: 4px;
color: #000;
} |
@MichelGabriel, thanks. I've updated the styling. |
In certain cases can be relevant to display a banner in the application to inform users, for example of a maintenance task.
This change request adds a new setting to enable an application banner and configure the text to display.
The banner is displayed in the public pages.
Checklist
main
branch, backports managed with labelREADME.md
filespom.xml
dependency management. Update build documentation with intended library use and library tutorials or documentation