Change icon for the layer tools in the layer manager panel on the map page #8376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… page. The tools in the layer manager in the map are opened on hover. But the icon was misleading, it invited you to click on it. When you hovered the layer the icon disappeared leading to the thought that you couldn't click the icon and therefore couldn't open a menu and missing some extra options (that weren't there). The tools are still opened on hover, making it clickable asks for some rebuilding, but the icon has changed and the color is dimmed.
|
I have cherry pick the commit to our environment (4.2.9) with HNAP schema. Deployed and got the looking like this.
Somehow there is some overlapping with layer removal buttons and this newly added arrow icon of the page. It makes the icon not clickable. I will do some confirmation test on the main branch to the latest GN. |
|
Here is the result I tested from latest GN4. If I dont hover my mouse, it looks ok. But if I try to hover my mouse to the arrow, the three pop buttons shows and there is no way I can click on that arrow sign.
Maybe we should offset either one a little? I dont know if screen resolution matter. But here is what my Windows OS setup
|
|
The tools menu is now opened on click 
|
|
It looks good.
|
wangf1122
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tools in the layer manager in the map are opened on hover. But the icon was misleading, it invited you to click on it. When you hovered the layer the icon disappeared leading to the thought that you couldn't click the icon and therefore couldn't open a menu and missing some extra options (that weren't there).
The tools are still opened on hover, making it clickable asks for some rebuilding, but the icon has changed and the color is dimmed.
Related to issue: #8116
The new look:
Checklist
mainbranch, backports managed with labelREADME.mdfilespom.xmldependency management. Update build documentation with intended library use and library tutorials or documentation