Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

道に関連する変更 #119

Closed
wants to merge 1 commit into from
Closed

道に関連する変更 #119

wants to merge 1 commit into from

Conversation

naogify
Copy link
Contributor

@naogify naogify commented Dec 14, 2022

Close #118

  • 高速道路の色とズームを調整
  • 高速道路の橋を削除
  • 全ての道路のトンネルのケーシングを削除
  • トンネルの色を変更

@netlify
Copy link

netlify bot commented Dec 14, 2022

Deploy Preview for style-gsi ready!

Name Link
🔨 Latest commit 99466ff
🔍 Latest deploy log https://app.netlify.com/sites/style-gsi/deploys/6399916cda530a000896119e
😎 Deploy Preview https://deploy-preview-119--style-gsi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@naogify naogify requested a review from u5t December 14, 2022 09:03
@github-actions
Copy link

✅ Style Rendering Time

ZoomDifference in Means [sec.]Mean ± Standard Deviation [sec.]Mean ± Standard Deviation [sec.] (Production)Significant Difference
5 -0.099 2.671 ± 0.675 (n = 5) 2.77 ± 0.418 (n = 5) -
7 +0.019 3.503 ± 0.221 (n = 5) 3.484 ± 0.093 (n = 5) -
11 -0.295 2.94 ± 0.307 (n = 5) 3.235 ± 0.446 (n = 5) -
14 -0.157 2.976 ± 0.224 (n = 5) 3.133 ± 0.19 (n = 5) -

n represents the number of samplings in each group.

The significant difference means the probability that the difference in means between the two groups is caused by coincidence due to sampling error, and 5% is used as the significance level.

@naogify
Copy link
Contributor Author

naogify commented Dec 14, 2022

@u5t
こちらのPRですが、大きい変更が2つあり、その理由を説明します。

高速道路の橋を削除

は、高速道路は大部分が橋のケースが多いので、橋と通常道路部分を一つのスタイルにしています。(カスタマイズ性もあがります)

全てのトンネルのケーシングを削除

は、トンネルの色自体を、地下の様な暗めの色に変更したのでケーシングが必要なくなったかなと思います。どうでしょうか?

@naogify
Copy link
Contributor Author

naogify commented Dec 16, 2022

#123 にマージしたためクローズします

@naogify naogify closed this Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

z6:高速道路情報表示
1 participant