Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace async-timer with futures-timer #324

Merged
merged 1 commit into from
May 24, 2024

Conversation

geofmureithi
Copy link
Owner

@geofmureithi geofmureithi commented May 22, 2024

Attempts to resolve #291 and #301 without a version bump

Copy link

Benchmark for b384ce2

Click to view benchmark
Test Base PR %
postgres/consume/1000 5.2±0.00s 5.2±0.00s 0.00%
postgres/push/1000 513.6±6.28ms 513.1±15.97ms -0.10%
redis/consume/1000 10.1±0.00s 10.1±0.00s 0.00%
redis/push/1000 159.6±1.03ms 160.1±0.81ms +0.31%
sqlite_in_memory/consume/1000 6.0±0.00s 6.0±0.00s 0.00%
sqlite_in_memory/push/1000 73.2±0.63ms 71.8±0.42ms -1.91%

@geofmureithi
Copy link
Owner Author

@IgnisDa does this solve your problem?

@IgnisDa
Copy link

IgnisDa commented May 24, 2024

@geofmureithi Seems to be working fine locally.

@geofmureithi geofmureithi merged commit f63480c into master May 24, 2024
5 checks passed
@geofmureithi geofmureithi deleted the bug/remove-async-timer branch May 24, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants