Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

static_ips should support plural azs in network definitions #201

Closed
geofffranks opened this issue Mar 14, 2017 · 0 comments
Closed

static_ips should support plural azs in network definitions #201

geofffranks opened this issue Mar 14, 2017 · 0 comments

Comments

@geofffranks
Copy link
Owner 

networks
- name: mynet
  subnets:
  - ... alll the usual stuff
    azs: [ z1, z2, z3 ]

is valid, but the operator currently only allows:

networks
- name: mynet
  subnets:
  - ... alll the usual stuff
    az: z1

We should fix this. Low priority, but in the mean time, adding the issue in case anyone else stumbles across this and needs a fix to could not find AZ z2 (in network AZS [z1 z2 z3]
@geofffranks geofffranks mentioned this issue Jul 10, 2017
Closed
geofffranks added a commit that referenced this issue Jul 10, 2017
@geofffranks
Fix #201 by supporting azs key in subnets
bced7de 
Previously only `az` was supported. Now when specifying
multiple AZs in a subnet, all IPs from that subnet can be
used in any instance_group/job that is in a zone that the
subnet mentioned.

This can lead to interesting scenarios when using mixes of
multi-az subnets and single-az subnets, where different offsets
can mean the same IP in a different zone, or the same index could
mean different IPs in different zones. Try not to do this, as it will
likely lead to confusion down the road. However, care is made to ensure
that IPs are never re-used, regardless of what subnets/azs they were
allowed to be used by.

This should not affect any existing IP allocations, since previously the
`azs` field wasn't looked at, and the old behaviors remain the same
for `az` and no-azs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@geofffranks