Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow radial resolution changes for multiple domains #537

Merged
merged 8 commits into from
Jun 21, 2024

Conversation

illorenzo7
Copy link
Contributor

This pull request should accomplish two main goals:

  1. Allow the user to increase the number of radial points in each Chebyshev sub-domain (even with multiple domains, e.g., ncheby=64, 96 --> ncheby = 96,256) and then restart from a checkpoint with the old (coarse) resolution. Before, the chebyshev coefficients weren't initialized correctly for multiple domains.

  2. Throw an error message and exit if the user tries to lower radial resolution in any subdomain. Before, the code would simply do nothing, likely integrating a bunch of zeros.

@illorenzo7
Copy link
Contributor Author

@feathern OK, this should be ready to be reviewed. I made logic so as to not touch the old code block that handles the single-domain case. The only place single-domain behavior will change is to throw an error and exit if the user tries to lower the resolution.

FYI I tested this by restarting from a checkpoint in (1) a simulation with a single domain and (2) a simulation with three subdomains. In each simulation, I tried lowering, raising, and not modifying the radial resolution and achieved the expected results.

Copy link
Contributor

@feathern feathern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm glad you contained the new functionality in its own conditional so that the single-domain checkpointing code remains unchanged! Approved.

@feathern feathern merged commit 3059de4 into geodynamics:main Jun 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants