Bug Fix: Checkpoint file size #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gassmoeller
reviewed
Jun 18, 2024
src/IO/Parallel_IO.F90
Outdated
| @@ -1573,6 +1574,11 @@ Subroutine Write_Data(self,disp,file_unit,filename) | |||
| If (present(filename)) Then | |||
| ! The file is not open. We must create it. | |||
| If (self%output_rank) Then | |||
| If (present(clear_existing)) Then | |||
| If (clear_existing) Then | |||
| Call MPI_File_delete(filename, MPI_INFO_NULL, ierr) | |||
There was a problem hiding this comment.
It looks like you are currently doing this unconditionally no matter if the file is present or not. Can MPI_File_delete handle the case if the file is not present? Or is it only called if the file exists and I missed the place where that is checked?
There was a problem hiding this comment.
As discussed this might be easier if you call MPI_FILE_set_size(funit, 0, ierr) after the call to MPI_FILE_OPEN, this would avoid the case where you dont know if the file already exists (because MPI_FILE_OPEN just created it).
gassmoeller
approved these changes
Jun 18, 2024
|
OK, this looks good and fixes the bug I was encountering. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in Rayleigh where a checkpoint file can appear to be too large if the file existed and was overwritten in a subsequent run with lower resolution. This PR ensures that the file is deleted before being written to, preventing this bug.