Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated AZ_Avgs class to allow concatenation and time-averaging. #500

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

feathern
Copy link
Contributor

This PR modifies the AZ_Avgs class so that it also accepts a list of multiple AZ_Avgs files. That data can either be concatenated or time-averaged as described in docstring. In addition, the class now contains an output method so that the current AZ_Avgs object structure can be saved to a new AZ_Avgs file.

Some notes:

  1. Single files can still be read as they always have been.
  2. This is a lot of new code. I've been using this new version of the AZ_Avgs class for a couple of years now. When doing a review, the most straightforward path is probably to test out the concatenation and time-averaging functionality.

Copy link
Contributor

@illorenzo7 illorenzo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @feathern

@illorenzo7 illorenzo7 merged commit a0c3e08 into geodynamics:main Apr 3, 2024
7 checks passed
@illorenzo7
Copy link
Contributor

@feathern It looks like the AZ_Avgs routine now prints "the_file" any time the class is instantiated from a binary file. I believe that was added in this pull request. Is this behavior strictly necessary or could I make a pull request to remove it? The only reason I care is that it's messing up some of the output from my personal routines (especially the parallelized ones).

@feathern
Copy link
Contributor Author

feathern commented May 9, 2024

Oops. Yes, please do go ahead and submit a PR with the fix. This was an oversight.

@feathern feathern deleted the AZ_Avgs branch May 10, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants