put c_8 into mm and pp enth_flux, dt_by_dp #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feathern
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Good catch. This got me thinking about how some of the other energy-equation-related outputs are scaled in a nondimensional, anelastic setup. I see now that you have issue related to this. We should definitely give some thought to this. In any event, this PR is approved -- thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the current calculation of enthalpy flux is inconsistent between the total flux and Reynolds decomposition (there is a missing c_8 in definition of dt_by_dp). I think it only affects non-dimensional cases, not the dimensional one (since they're c_8 = 1). This pull request should fix things.