-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breuer 2010 case0 bench #467
Breuer 2010 case0 bench #467
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two comments like we discussed earlier.
B_Bench/B_Bench_init
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like discussed earlier, please remove the files in the B_Bench
directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have two identical files b2010_case0_InitCond
and b2010_case0_initcond
. You probably only wanted to add one of them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you this looks good to go when the testers are done running. Congrats on your first PR! 🎉
@gassmoeller minor fix on the reference bib file to the Breuer 2010 paper. |
Added three input namelists (b2010_case0_0T_input, b2010_case0_80T_input, b2010_case0_100T_input) and the initial condition file to the input_examples. This provides the namelist to run the case 0 in Breuer 2010 GJI paper on Rayleigh. The notation "0T, 80T and 100T" represent 0 percent thermal - 100 percent chemical, 80 percent thermal - 20 percent chemical, and 100 percent thermal, 0 percent chemical separately.