Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breuer 2010 case0 bench #467

Merged
merged 6 commits into from
Jun 15, 2023

Conversation

cyan0226
Copy link
Contributor

Added three input namelists (b2010_case0_0T_input, b2010_case0_80T_input, b2010_case0_100T_input) and the initial condition file to the input_examples. This provides the namelist to run the case 0 in Breuer 2010 GJI paper on Rayleigh. The notation "0T, 80T and 100T" represent 0 percent thermal - 100 percent chemical, 80 percent thermal - 20 percent chemical, and 100 percent thermal, 0 percent chemical separately.

Copy link
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two comments like we discussed earlier.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like discussed earlier, please remove the files in the B_Bench directory.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have two identical files b2010_case0_InitCond and b2010_case0_initcond. You probably only wanted to add one of them?

Copy link
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you this looks good to go when the testers are done running. Congrats on your first PR! 🎉

@cyan0226
Copy link
Contributor Author

@gassmoeller minor fix on the reference bib file to the Breuer 2010 paper.

@gassmoeller gassmoeller merged commit 559d757 into geodynamics:main Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants