fixed bug in initialization of T_c for dimensional anelastic #445
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar in spirit from my #212 from a few years ago.
There was a bug in the definition of T_c for reference_type = 2 (dimensional anelastic mode). I believe T_c was being calculated from the ideal gas law assuming
gas_constant = c_p / (n + 1)
That is only true, however, for adiabatic gases (n = 1.5), not for other n's. In general it is
gas_constant = (gamma - 1) * c_p / gamma
where gamma = 5/3.