Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize scalar buoyancy coeffs2 #442

Merged
merged 3 commits into from
Jan 31, 2023
Merged

Initialize scalar buoyancy coeffs2 #442

merged 3 commits into from
Jan 31, 2023

Conversation

illorenzo7
Copy link
Contributor

Adds loops to Constant_Reference(), Polytropic_ReferenceND(), and Polytropic_Reference() to initialize the previously zeroed-out active-scalar buoyancy constants.

feathern
feathern approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@feathern feathern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Note that we need to revisit the buoyancy terms related to active scalar fields when they're used with a dimensional polytropic reference.

@feathern feathern merged commit a64e846 into geodynamics:main Jan 31, 2023
@illorenzo7 illorenzo7 deleted the initialize_scalar_buoyancy_coeffs2 branch February 14, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feathern feathern feathern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illorenzo7 @feathern