Adding Custom Background dSdr and dTdr via augment_reference. #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode. Small bug related to n_ra_constants and array dimensions fixed.
…ewadvec Fixed merge conflict.
illorenzo7
approved these changes
Dec 28, 2022
|
Ok. Given all the work you're doing in PDE_Coefficients.F90, I think it might be good to go ahead and merge this. Thanks for having a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for the user to modify the background dSdr and dTdr through the augment_reference routine. This functionality has been added to allow advection of a background temperature gradient in a Boussinesq model without the need to specify a full custom reference state. I've added this at the request of @jorafb , so I am assigning the review of this PR to him.