Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow that creates a docker container of Rayleigh #385

Merged

Conversation

gassmoeller
Copy link
Member

This adds a github action workflow to automatically create a docker image of Rayleigh when:

  1. A PR is merged into master. A new docker image with the tag geodynamics/rayleigh:latest is generated.
  2. A Rayleigh release is generated. A new docker image with the tag geodynamics/rayleigh:RELEASE_TAG is generated (where RELEASE_TAG is replaced by the tag of the release used by github).

The image that is generated itself is a bit outdated at the moment (it is based on the tester container using Ubuntu 18.04), but the workflow will use the Dockerfile in docker/rayleigh to build the image, so updating the Dockerfile will automatically update the docker image.

@gassmoeller
Copy link
Member Author

Oh, I should mention this does not add a test in this PR yet, because it only triggers when something is merged into master (so there is no way to see if it works, before this is merged). However, I have tested this with a modified version in my fork of Rayleigh (https://github.com/gassmoeller/Rayleigh/actions/runs/3053764309) and it produced an image correctly (https://hub.docker.com/repository/docker/gassmoeller/rayleigh).

Copy link
Contributor

@tukss tukss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me, but as you mention there is no way to check everything before it's merged. As this is only modifying the docker build, I suggest we merge this now and I'll do tests with the newly built container afterwards.

One question: It looks like this will only build containers for new releases. Do we also want to build containers also for the current and older releases? Or do we have those already?

@gassmoeller
Copy link
Member Author

One question: It looks like this will only build containers for new releases. Do we also want to build containers also for the current and older releases? Or do we have those already?

We do not have them at the moment. I would say let's first update the content of the image (to include Jupyter and the conda environment), then we can consider if we want to build images for older releases. I think it makes most sense getting the current and future versions.

@gassmoeller gassmoeller merged commit 303b9fc into geodynamics:master Sep 14, 2022
@gassmoeller gassmoeller deleted the build_rayleigh_docker_image branch September 14, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants